Skip to content

Migrate Marketplace Listing Stats on Contract Overview page to shadcn+tailwind #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

Migrate Marketplace Listing Stats on Contract Overview page to shadcn+tailwind #5040

merged 1 commit into from
Oct 15, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 15, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on refactoring the MarketplaceDetails and ListingStats components by replacing Flex components with standard div elements for layout, and it introduces a new StatCard component to streamline the display of statistics.

Detailed summary

  • Replaced Flex components with div elements in DirectListingCards, EnglishAuctionCards, and MarketplaceDetails.
  • Updated layout classes to use Tailwind CSS for styling.
  • Introduced a new StatCard component to display stats in ListingStatsV3.
  • Simplified the rendering of statistics with StatCard.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ccff347

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:06pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 15, 2024 9:06pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 15, 2024 9:06pm
wallet-ui ⬜️ Skipped (Inspect) Oct 15, 2024 9:06pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 15, 2024 20:44
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 15, 2024
@MananTank MananTank mentioned this pull request Oct 15, 2024
Merged
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank mentioned this pull request Oct 15, 2024
Merged
@MananTank MananTank changed the title Migrate Marketplace Listing Stats to shadcn+tailwind Migrate Marketplace Listing Stats on Contract Overview page to shadcn+tailwind Oct 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 2.6 s (-15.54% 🔽) 3.4 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 7.5 s (+13.74% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 351 ms (+71.15% 🔺) 448 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 88 ms (+87.11% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 448 ms (-59.63% 🔽) 795 ms

@codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (0cf478e) to head (ccff347).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5040   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54707    54707           
  Branches     3954     3954           
=======================================
  Hits        24786    24786           
  Misses      29230    29230           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0cf478e
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024 •
edited by jnsdls
Loading

Merge activity

@MananTank
Migrate Marketplace Listing Stats on Contract Overview page to shadcn…
ccff347 
…+tailwind (#5040)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on refactoring components in the `MarketplaceDetails.tsx` and `listing-stats.tsx` files to replace instances of the `Flex` component with standard `div` elements, while also introducing a new `StatCard` component for displaying statistics.

### Detailed summary
- Replaced `Flex` components with `div` elements in `DirectListingCards`, `EnglishAuctionCards`, and `MarketplaceDetails`.
- Introduced a new `StatCard` component in `listing-stats.tsx` for displaying statistics.
- Updated the rendering of total listings, direct listings, and English auctions to use `StatCard`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-16-migrate_contractchecklist_card_to_shadcn_stepscard_ui_adjustment branch from a51607e to 0cf478e Compare October 15, 2024 21:03
@jnsdls jnsdls force-pushed the 10-16-migrate_marketplace_listing_stats_to_shadcn_tailwind branch from 0391411 to ccff347 Compare October 15, 2024 21:03
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 21:04 Inactive
Base automatically changed from 10-16-migrate_contractchecklist_card_to_shadcn_stepscard_ui_adjustment to main October 15, 2024 21:08
@graphite-app graphite-app bot merged commit ccff347 into main Oct 15, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 10-16-migrate_marketplace_listing_stats_to_shadcn_tailwind branch October 15, 2024 21:09
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 15, 2024 21:09 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 15, 2024 21:09 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 15, 2024 21:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls